owner: fix checkpoint ts calculate in owner #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
july2993
reviewed
Dec 9, 2019
| @@ -494,18 +493,7 @@ func (o *ownerImpl) calcResolvedTs() error { | |||
| minCheckpointTs := cfInfo.TargetTs | |||
|
|
|||
| if len(cfInfo.tables) == 0 { | |||
There was a problem hiding this comment.
after this change when there no tables, the resolve ts can be forward and the checkpoint ts can not be forward?
There was a problem hiding this comment.
yes, in fact if there is no tables, the checkpoint ts is meaningless until cdc meets an add table DDL.
5kbpers
pushed a commit
to 5kbpers/ticdc
that referenced
this pull request
Aug 24, 2020
amyangfei
added a commit
to amyangfei/tiflow
that referenced
this pull request
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When the
StartTsof a changefeed is smaller than any none-system table DDL, we should have a right way to calculateglobal resolved tsandglobal checkpoint tsWhat is changed and how it works?
global resolved tscan use theddl resolved tsvalueglobal checkpoint tsto the local checkpoint cache stored inChangeFeedInfoCheck List
Tests